From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 18 May 2011 19:05:50 GMT
Subject: Re: [PATCH v7] Add log.abbrevCommit config variable
Message-ID: <7vwrhnbzht.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1305741364-28286-1-git-send-email-jaysoffian@gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> +test_expect_success 'log.abbrevCommit configuration' '
> +	test_when_finished "git config --unset log.abbrevCommit" &&

Now, when this test begins, what is the value of log.abbrevCommit?

I'd add an explicit

	test_might_fail git config --unset log.abbrevCommit &&

here.

> +	git log --abbrev-commit >expect.log.abbrev &&
> +...
> +	test_cmp expect.reflog.full actual

Break in && chain here.

> +	git whatchanged >actual &&
> +	test_cmp expect.whatchanged.abbrev actual

Ditto.

> +	git whatchanged --no-abbrev-commit >actual &&
> +	test_cmp expect.whatchanged.full actual
>  '
>  
>  test_expect_success 'show added path under "--follow -M"' '

I've squashed these in before queuing, so unless you found other issues,
no need to resend.

Thanks.