From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 23 May 2011 22:47:40 GMT
Subject: Re: [PATCH 5/5] combine-diff: respect textconv attributes
Message-ID: <7vwrhht4oj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110523203105.GE6298@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> +	} else if (textconv) {
> +		/* yuck, the textconv code is linked heavily with
> +		 * filespecs */
> +		struct diff_filespec *df = alloc_filespec("");
> +		fill_filespec(df, sha1, mode);
> +		*size = fill_textconv(textconv, df, &blob);

I thought your 4/5 talked something about not requiring filespec for
textconv handling...?  Is it still yuck?