From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 13 Dec 2011 18:34:23 GMT
Subject: Re: [PATCH/RFC 1/2] wrapper: supply xsetenv
Message-ID: <7vwra0uxqo.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111213181602.GB1663@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Tue, Dec 13, 2011 at 01:10:26PM +0100, Erik Faye-Lund wrote:
>
>> +int xsetenv(const char *name, const char *val, int overwrite)
>> +{
>> +	if (setenv(name, val, overwrite))
>> +		die_errno("setenv failed");
>> +}
>
> It probably doesn't matter, because the error condition is almost
> certainly just "oops, we ran out of memory". But you could also print
> the name of the variable being set, which may give the user a clue to
> some misconfiguration (e.g., trying to put some extremely long value
> into the environment).

Do we have enough memory to format that message in that situation ;-)?