From: Junio C Hamano Date: Mon, 26 Mar 2012 21:29:19 GMT Subject: Re: [PATCH v5 2/3] Refactor submodule push check to use string list instead of integer Message-ID: <7vwr67m4pc.fsf@alter.siamese.dyndns.org> In-Reply-To: <20120326195535.GA41511@book.hvoigt.net> Heiko Voigt writes: > It seems my guess was wrong. As far as I read in the code > string_list_insert() already skips inserting existing strings and just > returns the existing items in the list. So it should be fine to remove > the string_list_has_string() call. Sounds sane. Thanks.