From: Junio C Hamano Date: Mon, 28 May 2012 05:02:02 GMT Subject: Re: [PATCH 2/3] exclude: do strcmp as much as possible before fnmatch Message-ID: <7vwr3w6gqd.fsf@alter.siamese.dyndns.org> In-Reply-To: <7v8vgd7ap9.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > And this does not happen per path you check; exclude_stack used by > excluded() is designed to take advantage of the access pattern that > we tend to check paths from the same directory together, so such an > adjustment will be per directory switching (i.e. it will be part of > the prep_exclude() overhead that is amortized over paths you walk). Just in case it wasn't clear, I didn't mean to say "mine is the right way to do so; I will reject your patch that doesn't do so".