From: Junio C Hamano Date: Mon, 09 Jul 2012 23:18:13 GMT Subject: Re: [PATCH] Restore umasks influence on the permissions of work tree created by clone Message-ID: <7vwr2cikwa.fsf@alter.siamese.dyndns.org> In-Reply-To: <7v1ukkjzyz.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Jeff King writes: > >> Does the mkdir of "rr-cache/*" in rerere.c make the same mistake? The >> rr-cache root is made with 0777, and the files inside each subdirectory >> are created with 0666. So it is the only thing preventing users of >> shared repos from using rerere. > > Quite possibly yes. I do not recall tightening permissions on > purpose, and it was a long time ago ;-) Yup, that's the last remaining "mkdir(.*, 755)" in the codebase, and it should be trivial to replace it with mkdir_in_gitdir() or something.