From: Junio C Hamano Date: Mon, 17 Jun 2013 14:27:20 GMT Subject: Re: [PATCH] rebase -i: fixup fixup! fixup! Message-ID: <7vwqpshkxj.fsf@alter.siamese.dyndns.org> In-Reply-To: <8738shi2ht.fsf@linux-k42r.v.cablecom.net> Thomas Rast writes: > Conveniently enough we have seen both already ;-) Andrew's version for > commit.c could use a bit of refactorization, since it inserts the same > code in two places, but then it's about the same complexity as the > change for rebase. > > I'm not sure it's worth arguing about whether the "fixup! fixup!" is a > symptom of some underlying problem, and changing rebase is only tapering > over the symptom; or whether it's actually a useful distinction. If they are about the same complexity, then my instict tells me that it is a better design not to strip on the writing side. Thanks.