From: Junio C Hamano Date: Thu, 28 Apr 2005 16:11:37 GMT Subject: Re: I'm missing isofs.h Message-ID: <7vvf6698zq.fsf@assigned-by-dhcp.cox.net> In-Reply-To: >>>>> "LT" == Linus Torvalds writes: LT> On Wed, 27 Apr 2005, Junio C Hamano wrote: >> >> Linus & Andrew, is the above (second) format acceptable for the >> kernel work? LT> The only thing my stuff needs is that it's "-p1" format, ... Is /dev/null convention OK with you? I know it is OK for patch and cg-patch, both of which have built-in knowledge of the convention, but other tools may get confused. Here is an example of diffstat getting confused: $ jit-snap -v linus-mirror:0 Makefile comm-z.c # - [PATCH] diff-tree -p implies diff-tree -p -r # + JIT: indent help text from jit-snap. --- k/Makefile (mode:100644) +++ l/Makefile (mode:100644) @@ -7,7 +7,8 @@ # BREAK YOUR LOCAL DIFFS! show-diff and anything us..... # break unless your underlying filesystem supports ..... ... --- /dev/null +++ l/comm-z.c (mode:100644) @@ -0,0 +1,101 @@ +#include +#include ... $ jit-snap -v linus-mirror:0 Makefile comm-z.c | diffstat Makefile | 15 +++++++-- l/comm-z.c | 101 ++++++++++++++++++++++++++++++++++..... 2 files changed, 114 insertions(+), 2 deletions(-) LT> ... but I don't care LT> if the prefix is the sha1 tree-name, or "a/" and "b/" or anything else (I LT> think the current thing that the built-in stuff defaults to is a bit LT> strange. "k/" and "l/"? I understand "a/" and "b/", and I'd even get "x/" LT> and "y/" or "old/" and "new/", but starting counting at "l" is strange ;) I am _very_ glad somebody finally has noticed and voiced the puzzlement. It is meant to be a gentle reminder that the tool's primary purpose is to support development of l-k ;-). I do not mind if you told me to change them to a/ or b/ (or do it yourself---it is a single character change in the source) if you want.