From: Junio C Hamano Date: Thu, 17 Nov 2005 19:29:47 GMT Subject: Re: master has some toys Message-ID: <7vveyrt6ms.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: > I'd like to wait to have a reaction from other people. I vividly remember > my eyes falling out of my sockets when somebody reported success on cygwin > without NO_MMAP. If there is *any* cygwin version which fixes it, we > should rather make people upgrade, no? I am not so sure about forcing people upgrade, but we may end up deciding it is better not to have NO_MMAP as the default. If that turns out to be the case, I'd prefer to have something like this instead: diff --git a/Makefile b/Makefile index 7ce62e8..215abf0 100644 --- a/Makefile +++ b/Makefile @@ -213,6 +213,10 @@ endif ifeq ($(uname_O),Cygwin) NO_STRCASESTR = YesPlease NEEDS_LIBICONV = YesPlease + # There are conflicting reports about this. + # On some boxes NO_MMAP is needed, and not so elsewhere. + # Try uncommenting this if you see things break -- YMMV. + # NO_MMAP = YesPlease NO_IPV6 = YesPlease X = .exe endif