From: Junio C Hamano <junkio@cox.net>
Date: Fri, 09 Dec 2005 20:38:20 GMT
Subject: Re: [RFC/PATCH] git-prune: never lose objects reachable from our refs.
Message-ID: <7vvexy2egz.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051209193922.GA31228@ebar091.ebar.dtu.dk>

"Peter Eriksen" <s022018@student.dtu.dk> writes:

> On Thu, Dec 08, 2005 at 11:25:10PM -0800, Junio C Hamano wrote:
>> Explicit <head> arguments to git-prune replaces, instead of
>> extends, the list of heads used for reachability analysis by
>> fsck-objects.  By giving a subset of heads by mistake, objects
>> reachable only from other heads can be removed, resulting in a
>> corrupted repository.
>> 
>> This commit stops replacing the list of heads, and makes the
>> command line arguments to add to them instead for safety.
>
> Shouldn't the first sentence be "Explicit <head> arguments to git-prune
> extends, instead of replaces,...", that is, interchange the words 
> extends and replaces?  Did I miss something?

Sorry, what I meant was: "before this proposed change, it
replaces instead of extends --- which means DANGER.  This
proposed change is to make things safer".