From: Junio C Hamano <junkio@cox.net>
Date: Sat, 24 Jun 2006 00:21:12 GMT
Subject: Re: [PATCH] git-commit: filter out log message lines only when editor was run.
Message-ID: <7vveqr769z.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060623220405.1915.28636.stgit@gandelf.nowhere.earth>

Yann Dirson <ydirson@altern.org> writes:

> The current behaviour strips out lines starting with a # even when fed
> through stdin or -m.  This is particularly bad when importing history from
> another SCM (tailor 0.9.23 uses git-commit).  In the best cases all lines
> are stripped and the commit fails with a confusing "empty log message"
> error, but in many cases the commit is done, with loss of information.

I agree with this in principle but we would need to make sure
that our own scripts do not expect that the message is cleaned
up when feeding a commit log message via stdin, -m or -F, and if
they do fix them before applying this patch.