From: Junio C Hamano <junkio@cox.net>
Date: Sat, 23 Sep 2006 04:17:04 GMT
Subject: Re: [PATCH] Make cvsexportcommit work with filenames containing spaces.
Message-ID: <7vvenfw727.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060922223506.3377.34859.stgit@lathund.dewire.com>

Robin Rosenberg <robin.rosenberg@dewire.com> writes:

> Binary files are except to this so far.

Funny.  This works on my home machine (CVS 1.12.13) while it
does not pass test #2 "with spaces" on another machine that has
CVS 1.11.22.

> +. ./test-lib.sh
> +
> +export CVSROOT=$(dirname $(pwd))/cvsroot
> +export CVSWORK=$(dirname $(pwd))/cvswork

You are creating t/{cvsroot,cvswork} directories.  Do not
contaminate outside the test/trash directory your tests is
started in.

> +rm -rf $CVSROOT $CVSWORK

People's $(pwd) can contain shell $IFS characters, especially on
Cygwin.   Be careful and quote them when in doubt.