From: Junio C Hamano <junkio@cox.net>
Date: Sat, 24 Feb 2007 01:29:29 GMT
Subject: Re: [PATCH] Fixup no-progress for fetch & clone
Message-ID: <7vvehs1gxy.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0702240217550.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Since most servers will not have a no-progress aware upload-pack, how 
> about this? (It is slightly ugly, but at least works...)

Please no.

What's "slight" about this ugliness?

> +		if (no_progress && band != 3 && len > 7 + 5 &&
> +				!prefixcmp(buf + 7 + len - 5, "done\r"))
> +			continue;