From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 29 Sep 2007 22:11:31 GMT
Subject: Re: Fix revision log diff setup, avoid unnecessary diff generation
Message-ID: <7vve9tjf58.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.0.999.0709290932040.3579@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Sat, 29 Sep 2007, Pierre Habouzit wrote:
>>
>> -				if (strcmp(argv[i], "-z"))
>> -					revs->diff = 1;
>> +				revs->diff = strcmp(argv[i], "-z")
>> +					&& strcmp(argv[i], "--color")
>> +					&& strcmp(argv[i], "--no-color");
>
> The old code was already pretty damn ugly, the new code is worse (never 
> mind the bug).
>
> I don't think we should care *at*all* about the actual argument string, we 
> should just look at what the diffopts end up being at the end.

Thanks, I think this is the sanest thing to do.