From: Junio C Hamano Date: Thu, 25 Oct 2007 04:42:42 GMT Subject: Re: [PATCH 6/7] walk PATH to generate list of commands for "help -a" Message-ID: <7vve8v24al.fsf@gitster.siamese.dyndns.org> In-Reply-To: <1193283437-1706-6-git-send-email-srp@srparish.net> Scott R Parish writes: > Signed-off-by: Scott R Parish Rationale? There are two cases execv_git_cmd() runs "git-that" from a non standard place, if we take your [PATCH 4/7]. - If there is a directory that contains a location that used to hold an old installation of git-* commands (some of which may have been removed in the latest git) and if the user has that directory on PATH, we would run obsolete git subcommand from there. - If the user has a custom command "git-that" in $HOME/bin/ that is outside GIT_EXEC_PATH, the new subcommand "that" can be used as if it is part of the official git. This is an improvement [PATCH 4/7] would bring in. We allow this already for scripts anyway, and the patch is merely making the behaviour of the execv_git_cmd() consistent with it. It may be nicer if the user can somehow tell from the output if each of the command is from the standard set (i.e. on GIT_EXEC_PATH or built-in), or from a non standard place (either custom command as intended, or an unintended obsolete leftover).