From: Junio C Hamano Date: Wed, 05 Dec 2007 10:11:04 GMT Subject: Re: * [BUG] "git clean" does not pay attention to its parameters Message-ID: <7vve7dwix3.fsf@gitster.siamese.dyndns.org> In-Reply-To: Johannes Schindelin writes: > Hi, > > On Tue, 4 Dec 2007, Junio C Hamano wrote: > >> @@ -85,12 +86,17 @@ int cmd_clean(int argc, const char **argv, const char *prefix) >> read_directory(&dir, path, base, baselen, pathspec); >> strbuf_init(&directory, 0); >> >> - for (j = 0; j < dir.nr; ++j) { >> - struct dir_entry *ent = dir.entries[j]; >> - int len, pos, specs; >> + if (pathspec) { >> + for (i = 0; pathspec[i]; i++) >> + ; /* nothing */ >> + seen = xmalloc(); > > Did you mean xmalloc(i)? Yes.