From: Junio C Hamano Date: Tue, 24 Feb 2009 07:12:19 GMT Subject: Re: [PATCH] remote.c: make match_refs() copy src ref before assigning to peer_ref Message-ID: <7vvdr0l358.fsf@gitster.siamese.dyndns.org> In-Reply-To: <76718490902232253o4c7667d9h43f06d81794cef60@mail.gmail.com> Jay Soffian writes: > So there is no sane way to free the result. Yeah, I am not disagreeing that this is a good change to make the function easier to use. There is no question about it. I just found your description a bit unfair to the original author of the codepath who was probably fully aware of this. > I sent you a message off-list you may not have read yet. Yes I have, but I was deep into tonight's integration cycle (I earlier asked you to check the rebased result when I push it out --- that is what I've been preparing). I am almost done, and it will be pushed out shortly, but it won't have your re-roll. That will be after 1.6.2-rc2.