From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Mar 2009 16:48:20 GMT
Subject: Re: [PATCH v3] send-email: add --confirm option and configuration setting
Message-ID: <7vvdqqblij.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <76718490903030822j690cb97blea292d391c0d0112@mail.gmail.com>

Jay Soffian <jaysoffian@gmail.com> writes:

> On Tue, Mar 3, 2009 at 6:54 AM, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
>> On Tue, Mar 3, 2009 at 05:52, Jay Soffian <jaysoffian@gmail.com> wrote:
>>> diff --git a/git-send-email.perl b/git-send-email.perl
>>> index adf7ecb..57127aa 100755
>>> --- a/git-send-email.perl
>>> +++ b/git-send-email.perl
>>> @@ -837,6 +837,37 @@ X-Mailer: git-send-email $gitversion
>>>        unshift (@sendmail_parameters,
>>>                        '-f', $raw_from) if(defined $envelope_sender);
>>>
>>> +       if ($needs_confirm && !$dry_run) {
>> So, the output is now differnt with and without --dry-run?
>
> There doesn't seem to be any point in having the user confirm before
> sending the message if the message is not actually going to be sent.
> Am I missing something?

I do not think you are missing anything.

IIRC, the --dry-run mode shows more clearly to whom you would be CC'ing
the messages; in other words, the behaviour would be different, but it
gives an uninteractive way to confirm, and not pausing for confirmation is
a good thing.