From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 08 Mar 2009 20:24:21 GMT
Subject: Re: [PATCH 1/4] parseopt: add PARSE_OPT_KEEP_UNKNOWN
Message-ID: <7vvdqjkbka.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <49B40A9F.7050408@lsrfire.ath.cx>

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Add a parseopt flag, PARSE_OPT_KEEP_UNKNOWN, that can be used to keep
> unknown options in argv, similar to the existing KEEP flags.

Very nice.

The only caveat I can think of is with PARSE_OPT_STOP_AT_NON_OPTION set
(which is not default), you can correctly handle:

	git cmd --known --unknown=value arg0 arg1

but cannot correctly handle:

	git cmd --known --unknown value arg0 arg1

An update to Documentation/technical/api-parse-options.txt that

 (1) describes this new option; and

 (2) warns about this issue.

It might even make sense to diagnose PARSE_OPT_STOP_AT_NON_OPTION used
together with PARSE_OPT_KEEP_UNKNOWN as a programming error.