From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 19 Mar 2009 22:01:40 GMT
Subject: Re: [PATCH] Microoptimize strbuf_cmp
Message-ID: <7vvdq56ukb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090319210931.GB31014@blimp.localdomain>

Alex Riesen <raa.lkml@gmail.com> writes:

> Make it inline and cleanup a bit. It is definitely less code
> including object code, but it is not always measurably faster
> (but mostly is).

The only in-tree user seems to be rerere, so inlining for that single
caller will reduce the object side, but I am not sure if this is a good
change in the longer term if we want to encourage the use of strbuf
library.

The rewrite of the logic does seem worth doing, though.