From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 08 Apr 2009 19:20:48 GMT
Subject: Re: [PATCH 6/8] archive: use index instead of parsing tree directly
Message-ID: <7vvdpfj6jz.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1239185133-4181-7-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Currently:
>
>  - "git archive" parses trees directly
>  - attr mechanism does not support in-tree attributes
>
> Making attr.c support in-tree attributes is quite a non-trivial task,
> IMHO. Instead this patch makes "git archive" read tree to index first,
> then start exporting from there.
>
> One minor regression: "git archive" now will no longer generate
> directory entries, only files.

Hmmm, if you read_tree() into the_index upfront and do not change anything
else to the archive.c code, shouldn't it work without such a regression at
all?  Am I missing something?

It would allow you to export the index into an archive, but I doubt it is
worth the amount of code churn.