From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 06 Aug 2009 19:21:07 GMT
Subject: Re: Message from git reset: confusing?
Message-ID: <7vvdl0kau4.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqprb946sk.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> This is my biggest issue, indeed. Actually, several things bother me
> (by decreasing annoyance):
>
> 1) It looks like an error message, and user can think git reset
> failed.
>
> 2) It's inconsistant with the usual status display. I'd prefer an
> output like "git diff --name-only" or "git status".
> ...
> So, let's address 1) and 2) only.
>
> Any opinion? Am I going in the right direction?

I think the approach is sane.  I didn't check if the unconditional 

	printf("Unstaged changes after reset:\n");

needs to be protected, or at that point we already know we will talk about
one or more paths (either needs update or needs merge).