From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 30 Oct 2009 22:43:52 GMT
Subject: Re: [PATCH 3/8] Teach git var about GIT_EDITOR
Message-ID: <7vvdhwfqon.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091030224737.GA16565@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> writes:

> I am a bit uncomfortable with this error in general.  It makes some
> sense to refuse to use $VISUAL and fall back to $EDITOR if TERM=dumb,
> since without this the distinction between VISUAL and EDITOR is not
> very useful.

More importantly, that is what people traditionally expected from VISUAL
and EDITOR and we do that only to follow suit.

There is no such tradition for GIT_EDITOR nor core.editor and switching
behaviour based on the name of editor ("vi"? "vim"?...) does not feel
quite right.