From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 02 Apr 2010 07:12:22 GMT
Subject: Re: [PATCH 7/7] diff: avoid useless filespec population
Message-ID: <7vvdcal44p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100402001424.GG16462@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> This patch just pushes the fill_mmfile call a bit later, so we can avoid
> populating the filespec in some cases.  There is one thing to note that
> looks like a bug but isn't. We push the fill_mmfile down into the first
> branch of a conditional. It seems like we would need it on the other
> branch, too, but we don't; fill_textconv does it for us (in fact, before
> this, we were just writing over the results of the fill_mmfile on that
> branch).

... and leaking the memory in the "cached" codepath, perhaps?

> I remember when I first started using git having it go so fast that I
> had to double-check that it had actually worked correctly. I had another
> of those moments when I ran this. But it correctly processed everything
> I threw at it. More stress-testing appreciated. :)

Heh.  Will queue.

Thanks.