From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 14 Jun 2010 05:33:55 GMT
Subject: Re: [PATCH v2 1/2] add --recode-patch option to git-mailinfo
Message-ID: <7vvd9mb2kc.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1276455040-14726-1-git-send-email-r0bertz@gentoo.org>

Zhang Le <r0bertz@gentoo.org> writes:

> diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
> index 4a9729b..73f51f3 100644
> --- a/builtin/mailinfo.c
> +++ b/builtin/mailinfo.c
> @@ -830,6 +831,8 @@ static int handle_commit_msg(struct strbuf *line)
>  
>  static void handle_patch(const struct strbuf *line)
>  {
> +	if (recode_patch)
> +		convert_to_utf8(line, charset.buf);

builtin/mailinfo.c: In function 'handle_patch':
builtin/mailinfo.c:835: error: passing argument 1 of 'convert_to_utf8' discards qualifiers from pointer target type

I do not think there is a reason for "line" to be const anymore; it used
to make sense back when handle_patch() was only about writing the patch
out, but that no longer is the case.