From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 02 Aug 2010 15:26:18 GMT
Subject: Re: [PATCH 1/3 v4] Add a macro DIFF_QUEUE_CLEAR.
Message-ID: <7vvd7tnihx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100802124729.GK12084MdfPADPa@purples>

Sven Verdoolaege <skimo@kotnet.org> writes:

> On Thu, May 06, 2010 at 09:52:27PM -0700, Bo Yang wrote:
>> Refactor the diff_queue_struct code, this macro help
>> to reset the structure.
>> 
> [..]
>> 
>> diff --git a/diff.c b/diff.c
>> index e40c127..4a350e3 100644
>> --- a/diff.c
>> +++ b/diff.c
>> @@ -2540,6 +2540,7 @@ static void run_checkdiff(struct diff_filepair *p, struct diff_options *o)
>>  void diff_setup(struct diff_options *options)
>>  {
>>  	memset(options, 0, sizeof(*options));
>> +	memset(&diff_queued_diff, 0, sizeof(diff_queued_diff));
>>  
>
> What's this line for?

I don't think this change is warranted.  The macro was supposed to reduce
the repetition of assignment to q->queue, q->nr and q->alloc, and nothing
else.

Also the commit messages in this series are unreadable---I should have
been a bit more careful.

Sorry and thanks for noticing.