From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 06 Aug 2010 19:42:47 GMT
Subject: Re: [PATCH v4 03/18] Add the basic data structure for line level history
Message-ID: <7vvd7n7cjs.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1281024717-7855-4-git-send-email-struggleyb.nku@gmail.com>

Bo Yang <struggleyb.nku@gmail.com> writes:

> diff --git a/diffcore.h b/diffcore.h
> index 491bea0..13d8e93 100644
> --- a/diffcore.h
> +++ b/diffcore.h
> @@ -23,6 +23,7 @@
>  #define MINIMUM_BREAK_SIZE     400 /* do not break a file smaller than this */
>  
>  struct userdiff_driver;
> +struct diff_options;

Hmm...  I do not see anything you added to this header file that needs
such a forward declaration.  Other files you added that include diffcore.h
may want to have that declaration, but I do not think this header file does.

>  
>  struct diff_filespec {
>  	unsigned char sha1[20];

> diff --git a/line.h b/line.h
> new file mode 100644
> index 0000000..caf84c7
> --- /dev/null
> +++ b/line.h
> @@ -0,0 +1,128 @@
> ...
> +struct print_range {
> +	int start, end;
> +	int pstart, pend;

Please describe what these fields mean.

> +struct range {

Isn't "range" too generic a term?  Unless you make this as a static
declaration only visible to functions where "range" can only mean "line
ranges" in their context, that is.