From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Aug 2010 17:39:46 GMT
Subject: Re: [PATCH v2 3/3] {fetch,upload}-pack: allow --depth=0 for infinite depth
Message-ID: <7vvd6zx63h.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20100824135341.GA6457@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Aug 23, 2010 at 10:08:24PM +1000, Nguyễn Thái Ngọc Duy wrote:
>
>> Users can do --depth=2147483648 for infinite depth now. It just looks
>> ugly. So make "0" special (i.e. infinite depth) at plumbing/protocol
>> level.
>
> What happens if I connect to an older server? Shouldn't "I understand
> depth=0 is infinite" be a server capability, and we hack around it by
> sending depth=2^32-1 when we have a modern client but an older server?

Good point.  Do we also need to find out how wide an int is on the other
end in that case?