From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 01 Sep 2010 17:31:45 GMT
Subject: Re: Why isn't builtin.h used by all builtin/*.c files?
Message-ID: <7vvd6p5q0u.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4C7E69A5.4070008@gmail.com>

Stephen Boyd <bebarino@gmail.com> writes:

>  On 09/01/2010 07:17 AM, Ævar Arnfjörð Bjarmason wrote:
>> I'm working on gettextizing the 'mainporcelain common' commands now,
>> and I ran into this:
>>
> [snip]
>>
>> Anyway, I'll convert these to builtin.h where appropriate as part of
>> the series unless someone can find a good reason not to.
>
> Sparse warns about this too. "Prototype not found, should it be static?"
> for a few cmd_*'s. So sounds good to me.

Sounds good to me, too.