From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 14 Nov 2010 19:08:35 GMT
Subject: Re: [PATCH 1/4] Makefile: move "Platform specific tweaks" above LIB_{H,OBJS}
Message-ID: <7vvd3z205o.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1289745857-16704-2-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> Change the Makefile so that the "Platform specific tweaks" section
> comes before the assignments to LIB_H and LIB_OBJS.
>
> In the ab/i18n series I only want to build gettext.o (by adding it to
> LIB_OBJS) if NO_GETTEXT is unset. It's not possible to do that without
> an ugly hack if we haven't applied our platform specific tweaks before
> LIB_{H,OBJS} gets assigned to.

Isn't this similar to block-sha1, which is controlled by the feature macro
BLK_SHA1 that can be inferred from platform tweak?  The mechanism is not a
hack but is a way LIB_H and LIB_OBJS are intended to be used, so there
must be something missing in your explanation.