From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Nov 2010 17:44:41 GMT
Subject: Re: [PATCH v3] help: always suggest common-cmds if prefix of cmd
Message-ID: <7vvd3g58ja.fsf@alter.siamese.dyndns.org>
In-Reply-To: <AANLkTin34AfYnFY5e9B1cuyckfLXU2=qXFciFaaNGt9f@mail.gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

> For this code-path to trigger we would have to be able to prefix-match
> every common command AND every "main command" must be included in
> common commands. At the same time. The only possible way to
> prefix-match all commands is if they all start with the same letter.
> Do you really think this is a situation we could ever end up in? Every
> git command being a common-command, starting with the same letter?
>
> This is basically unreachable code. Perhaps it'd be even clearer just to die:
>
> if (main_cmds.cnt <= n)
> 	die("Prefix-matched everyting, what's going on?");

Well, the same letter can be an empty string:

	$ git ''

Didn't I already suggest BUG() there?  Also, saying "too ambiguous" would
make the codepath give "... See 'git --help'" message, I think.