From: Junio C Hamano Date: Sat, 22 Jan 2011 00:30:34 GMT Subject: Re: [PATCH 4/5] fast-export: Introduce --inline-blobs Message-ID: <7vvd1hn5jp.fsf@alter.siamese.dyndns.org> In-Reply-To: <1295415899-1192-5-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra writes: > + buf = read_sha1_file(spec->sha1, &type, &size); > + if (!buf) > + die ("Could not read blob %s", > + sha1_to_hex(spec->sha1)); Style; no SP after "die", as it is a function, not syntactic elements like if/switch/while (look everywhere).