From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 18 Apr 2011 21:40:31 GMT
Subject: Re: [REGRESSION] git-wrapper to run-commands codepath regression
Message-ID: <7vvcyb6xww.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110418211849.GB13566@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> And here's the fix.

I was tempted to suggest the change in your patch.

With ebec842 (run-command: prettify -D_FORTIFY_SOURCE workaround,
2011-03-16) reverted, I still don't get complaints from -D_FORTIFY_SOURCE
for run-command.c (but I do get "ignoring return value of 'fwrite' from
many places).  Perhaps the kinds of checks done by versions of gcc you,
Jonathan and I use are different.

I'd rather revert it for now; I don't want to see patch ping-pong at this
late in the pre-release cycle.