From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 May 2011 16:18:35 GMT
Subject: Re: [PATCH] t3703, t4208: add test cases for magic pathspec
Message-ID: <7vvcxjq23o.fsf@alter.siamese.dyndns.org>
In-Reply-To: <BANLkTikONPUVvAEw+fSDva8RUp-YSm-Nxw@mail.gmail.com>

Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:

>> Shouldn't
>>
>>        $ git anycmd :
>>
>> be equivalent to
>>
>>        $ (cd $(git rev-parse --show-cdup)/. && git anycmd)
>>
>> for any command?  I doubt this test is expecting the right outcome.
>> Shouldn't it result in "Nothing specified, nothing added."?
>
> It's gray area.

I do not see anything gray in it.

"git add :" in subdirectory is simply broken because we have used "No
remaining command line argument means no pathspec" when deciding to stop
and say "Nothing specified, nothing added".  That was a sensible
assumption back then, but it needs to be updated to take the new "The
remaining command line argument may say that there is no pathspec" reality
into account.