From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 18 Oct 2011 07:55:44 GMT
Subject: Re: [PATCH 3/3] completion: match ctags symbol names in grep patterns
Message-ID: <7vvcrmhgxr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqpqhug31l.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Junio C Hamano <gitster@pobox.com> writes:
>
>>>> +git_check = $(shell git ls-files >/dev/null 2>&1; echo $$?)
>>>> +ifeq ($(git_check),0)
>
>> Hmm, how would this punish anybody exactly (I just took the structure
>> from the way how the auto-depend is done)?
>
> The "shell git ls-files" is ran unconditionnally, hence a small
> performance penality even if you don't run ctags.

You mean it is run once whenever you type "make <RETURN>"?  Doesn't the
same argument apply for the auto-depend thingy against "make doc<RETURN>"?