From: Junio C Hamano Date: Thu, 15 Dec 2011 17:43:14 GMT Subject: Re: [BUG] in rev-parse Message-ID: <7vvcphohn1.fsf@alter.siamese.dyndns.org> In-Reply-To: <20111215070521.GB1327@sigill.intra.peff.net> Jeff King writes: > Dropping the implied verify is easy (see below). But handling > non-existant sha1s is a much more complicated change, as the regular > abbreviation machinery assumes that they exist. Hmm, I was very sure that I wrote a logic to do the "no such object" case at least once, so I looked and found one in find_unique_abbrev(). But that requires the caller to feed the full 160-bit sha1[] and perhaps it is not easily used in the context of rev-parse (I didn't look further). > Anyway, I'm not sure it's worth changing at this point. It's part of the > plumbing API that has been that way forever,... Ok.