From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 May 2012 18:36:25 GMT
Subject: Re: [PATCH 02/19] tests: add tests for the bash prompt functions in the completion script
Message-ID: <7vvck5ryl2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1336524290-30023-3-git-send-email-szeder@ira.uka.de>

SZEDER Gábor <szeder@ira.uka.de> writes:

> The tests cover the discovery of the '.git' directory in the __gitdir()
> function in different scenarios, and the prompt itself, i.e. branch
> name, detached heads, operations (rebase, merge, cherry-pick, bisect),
> and status indicators (dirty, stash, untracked files; but not the
> upstream status).
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>

Looks like a quite comprehensive tests around GIT_PS1_$MANY_DIFFERENT_STYLES
(except that GIT_PS1_SHOWUPSTREAM seems to be missing); very nice.

> +	echo 1 > file &&

When you are going to re-roll to add the missing SHOWUPSTREAM test, in
addition to J6t's $PWD vs $(pwd) vs $TRASH_DIRECTORY fix, please fix these
redirections to match the coding styles (i.e. "cmd >file" and "cmd <file",
with SP before and without SP after redirection operators).