From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 28 Aug 2012 17:53:06 GMT
Subject: Re: [PATCH v7 08/16] remote-svn, vcs-svn: Enable fetching to private refs
Message-ID: <7vvcg228tr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1346143790-23491-9-git-send-email-florian.achleitner.2.6.31@gmail.com>

Florian Achleitner <florian.achleitner.2.6.31@gmail.com> writes:

> The reference to update by the fast-import stream is hard-coded.  When
> fetching from a remote the remote-helper shall update refs in a
> private namespace, i.e. a private subdir of refs/.  This namespace is
> defined by the 'refspec' capability, that the remote-helper advertises
> as a reply to the 'capabilities' command.
>
> Extend svndump and fast-export to allow passing the target ref.
> Update svn-fe to be compatible.
>
> Signed-off-by: Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> ...
> diff --git a/vcs-svn/svndump.c b/vcs-svn/svndump.c
> index d81a078..288bb42 100644
> --- a/vcs-svn/svndump.c
> +++ b/vcs-svn/svndump.c
> @@ -299,22 +299,22 @@ static void handle_node(void)
>  				node_ctx.text_length, &input);
>  }
>  
> -static void begin_revision(void)
> +static void begin_revision(const char *remote_ref)
>  {
>  	if (!rev_ctx.revision)	/* revision 0 gets no git commit. */
>  		return;
>  	fast_export_begin_commit(rev_ctx.revision, rev_ctx.author.buf,
>  		&rev_ctx.log, dump_ctx.uuid.buf, dump_ctx.url.buf,
> -		rev_ctx.timestamp);
> +		rev_ctx.timestamp, remote_ref);
>  }
>  
> -static void end_revision(void)
> +static void end_revision()

Don't.

>  {
>  	if (rev_ctx.revision)
>  		fast_export_end_commit(rev_ctx.revision);
>  }