From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 10 Jan 2013 22:51:11 GMT
Subject: Re: [RFC/PATCH] avoid SIGPIPE warnings for aliases
Message-ID: <7vvcb4ejog.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50EF380A.9010809@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> The interesting cases are when git reads back the output of the command.
> Here, a SIGPIPE death of the child would indicate a bug in git, I think,
> and some diagnostic would be worth it. But we can just as well declare
> that git doesn't have bugs ;)
>
> These are the interesting cases:
> connect.c:640:          conn->use_shell = 1;
>     a connection to a local repository
> convert.c:372:  child_process.use_shell = 1;
>     clean/smudge filter
> credential.c:216:       helper.use_shell = 1;
>     credential helper
> diff.c:4851:    child.use_shell = 1;
>     textconv
>
> All in all, I think the heuristics makes sense.

Fair enough.  Thanks for grepping.