From: Junio C Hamano Date: Thu, 14 Mar 2013 03:30:38 GMT Subject: Re: [PATCH 0/4] contrib/subtree: general updates Message-ID: <7vvc8uzmht.fsf@alter.siamese.dyndns.org> In-Reply-To: <874ngebsm9.fsf@catnip.gol.com> Miles Bader writes: > Paul Campbell writes: >> James and Michael's patches add if clauses that use the >> bashism 'if []' rather than 'if test'. > > "Bashism"...? I dunno how portable is, but "[" is an old unix alias > for "test" ... it certainly predates bash... Correct. [[ ... ]] is new and spelling out "test" indeed is more traditionalist than [ ... ], but for contrib/subtree/ that does not work with anything but bash, I do not think such a rewrite has much merit in the first place. Being consistently "bash script" (as opposed to being old-style) is more appropriate for it.