From: Junio C Hamano Date: Thu, 12 Jan 2006 00:05:05 GMT Subject: [PATCH - maint review] describe: do not silently ignore indescribable commits Message-ID: <7vu0cajopa.fsf@assigned-by-dhcp.cox.net> We silently ignored indescribable commits without complaining. Complain and die instead. Signed-off-by: Junio C Hamano --- * For 1.1.2 describe.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) 8c23b6fae2e5cd8475885b015f0bb992d19921db diff --git a/describe.c b/describe.c index a0180f5..5548a16 100644 --- a/describe.c +++ b/describe.c @@ -124,10 +124,11 @@ static void describe(struct commit *cmit if (n) { printf("%s-g%s\n", n->path, find_unique_abbrev(cmit->object.sha1, abbrev)); - break; + clear_commit_marks(cmit, SEEN); + return; } } - clear_commit_marks(cmit, SEEN); + die("cannot describe '%s'", sha1_to_hex(cmit->object.sha1)); } int main(int argc, char **argv) -- 1.1.1-g8ecb