From: Junio C Hamano <junkio@cox.net>
Date: Fri, 03 Feb 2006 19:56:54 GMT
Subject: Re: [PATCH] do not open editor in dumb terminal
Message-ID: <7vu0bgdxmh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060203114133.GA11499@kvasir.watson.ibm.com>

Amos Waterland <apw@us.ibm.com> writes:

> Many people run git from a shell in emacs (obtained by M-x shell).  When
> they try to do a commit without specifying a log message on the command
> line with -m, git opens vi inside emacs, with unpleasant results.  I
> think the right answer is to just refuse to open an editor in any dumb
> terminal.

No, please don't.

I run 'git commit' from M-x shell or M-x compile.  My EDITOR is
set to 'emacsclient' while inside Emacs.

As a matter of fact, I do almost all my work inside Emacs and
this setting works rather well for not only git but for other
people's commands (like 'cvs commit').

It might be an option not to fall back on vi and instead to fall
back on ed/ex when neither EDITOR nor VISUAL is specified and
the terminal is dumb.  But the patch as-is is unacceptable.