From: Junio C Hamano <junkio@cox.net>
Date: Tue, 15 Aug 2006 00:29:24 GMT
Subject: Re: [PATCH 2/9] gitweb: Separate ref parsing in git_get_refs_list into parse_ref
Message-ID: <7vu04ec04b.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <200608140207.01108.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> Note that for each ref there are usually two calls to git subroutines:
> first to get the type of ref, second to parse ref if ref is of commit
> or tag type.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
>  gitweb/gitweb.perl |   80 +++++++++++++++++++++++++++++-----------------------
>  1 files changed, 45 insertions(+), 35 deletions(-)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 28df59e..0c4ec92 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -690,6 +690,49 @@ sub parse_commit {
>  	return %co;
>  }
>  
> +# parse ref from ref_file, given by ref_id, with given type
> +sub parse_ref {
> +	my $ref_file = shift;
> +	my $ref_id = shift;
> +	my $type = shift || git_get_type($ref_id);

This git_get_type() is additional from the original.
Future-proofing yourself for other new callers?