From: Junio C Hamano <junkio@cox.net>
Date: Tue, 14 Nov 2006 17:42:34 GMT
Subject: Re: [PATCH 2/5] support fetching into a shallow repository
Message-ID: <7vu011zzzp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0611141140530.13772@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> I think the "commit = p->item" part is trying to do a tail
>> recursion optimization, but this is a bit too clever to my
>> liking (at first I mistook that the code forgot to re-point p at
>> its parents list and incrementing cur_depth).
>
> I take it as a compliment ;-)
>
> Seriously again, would you like me to add a comment, or rather do away 
> with the tail recursion optimization? It is not a huge optimization 
> anyway. Maybe a cleverer way would be to use an object_array instead of a 
> commit_list?

Leaving it as a compliment is just fine.