From: Junio C Hamano <junkio@cox.net>
Date: Mon, 27 Nov 2006 21:55:21 GMT
Subject: Re: SEGV when lookup_* returns NULL
Message-ID: <7vu00kftbq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061127211315.GC18810@admingilde.org>

Martin Waitz <tali@admingilde.org> writes:

> All the lookup_{blob,tree,commit} functions check that the object
> really is of the requested type and return NULL otherwise.
> However this NULL pointer is not checked in the calling functions.
>
> Should we make lookup_* to just die when invoked on another object-type?

Making lookup_{specific type} die when they see unexpected type
would not hurt that much, I think, aside from the possibility
that some callers may check NULL to see if object already
exists, but they should be using has_sha1_file() instead.