From: Junio C Hamano <junkio@cox.net>
Date: Sun, 31 Dec 2006 06:03:34 GMT
Subject: Re: [PATCH 3/3] Use /dev/null for update hook stdin.
Message-ID: <7vtzzciouh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061231025522.GC5530@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Currently the update hook invoked by receive-pack has its stdin
> connected to the pushing client.  The hook shouldn't attempt to
> read from this stream, and doing so may consume data that was
> meant for receive-pack.  Instead we should give the update hook
> /dev/null as its stdin, ensuring that it always receives EOF and
> doesn't disrupt the protocol if it attempts to read any data.

Both 2 and 3 look sane, but can we have a few new tests too?