From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 28 Jun 2007 04:29:45 GMT
Subject: Re: [PATCH] Ignore end-of-line style when computing similarity score for rename detection
Message-ID: <7vtzssog5i.fsf@assigned-by-dhcp.pobox.com>
In-Reply-To: <46831F70.2060403@midwinter.com>

I wonder if we have a path or the attribute cue at this point of
the operation.  Your patch may solve that special case of CRLF
mangled files, but diffcore-delta works both on text and binary
and I am not sure what damange/side-effect you are causing.

And you are not ignoring "\r\n vs \n difference" as the comment
claims, but are discarding '\r' unconditionally.  When we start
doing something like that, I would feel much better if we _know_
we are operating on a text file at least.