From: Junio C Hamano Date: Fri, 31 Aug 2007 21:46:55 GMT Subject: Re: git-svn: Protect against "diff.color = true". Message-ID: <7vtzqfwf5c.fsf@gitster.siamese.dyndns.org> In-Reply-To: Johannes Schindelin writes: > On Fri, 31 Aug 2007, Junio C Hamano wrote: > >> I do not have an easy access to SVN repo >> to interoperate with, so a testing by real-world users and an >> Ack is appreciated. > > I just tested on a busybox clone: Works as expected. Without your patch, > I get the uninitialised values, with your patch it is fine. > > ACK. Thanks. It's customary that the privilege to issue Ack is reserved to the primary owner of the code. We are a relatively small friendly community and it is not a big deal, but if you ever work on the kernel, be somewhat more careful. People are picky over there on such details.