From: Junio C Hamano Date: Mon, 17 Sep 2007 06:06:46 GMT Subject: Re: metastore Message-ID: <7vtzpt3jwp.fsf@gitster.siamese.dyndns.org> In-Reply-To: david@lang.hm writes: > On Sun, 16 Sep 2007, Junio C Hamano wrote: > >> I also need to rant here a bit. >> >> Fortunately we haven't had this problem too many times on this >> list, but sometimes people say "Here is my patch. If this is >> accepted I'll add documentation and tests". I rarely reply to >> such patches without sugarcoating my response, but my internal >> reaction is, "Don't you, as the person who proposes that change, >> believe in your patch deeply enough to be willing to perfect it, >> in order to make it suitable for consumption by the general >> public, whether it is included in my tree or not? A change that >> even you do not believe in yourself has very little chance of >> benefitting the general public, so thanks but no thanks, I'll >> pass." > > I hope that my questions did not seem to fall into this catagory. Not at all.