From: Junio C Hamano Date: Tue, 18 Dec 2007 01:08:44 GMT Subject: Re: FLEX_ARRAY=1 causes SIGSEGV on SPARC Message-ID: <7vtzmg3j37.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20071218010126.GP14735@spearce.org> "Shawn O. Pearce" writes: > I'll try to track it down tomorrow. But the immediate workaround was > to just add '-DFLEX_ARRAY=/* empty */' to my CFLAGS and recompile > the world. This compiler accepts the empty FLEX_ARRAY macro but > I'm not sure what feature test(s) would be necessary to make Git > able to automatically set that, seeing as how the tests defined in > 8e97 are perfectly reasonable and didn't pass. > ..., but will try to come up with a reasonable > detection patch.... Actually I would be more worried about the breakage in FLEX_ARRAY=1 case than misdetection. Even if your compiler supports the flexible array members, the fallback to FLEX_ARRAY=1 ought to work and you are seeing a case where it doesn't.